Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ParamSpec to replace ... in Callable #25658

Merged
merged 1 commit into from
Aug 12, 2022
Merged

Use ParamSpec to replace ... in Callable #25658

merged 1 commit into from
Aug 12, 2022

Conversation

uranusjr
Copy link
Member

For whatever reason, this makes PyLance able to infer the wrapped function's signature, which is a nice improvement.

Before:
Screenshot 2022-08-11 at 15 56 09

After:
Screenshot 2022-08-11 at 15 56 30

@uranusjr
Use ParamSpec to replace ... in Callable
4e2b41b 
For whatever reason, this makes PyLance able to infer the wrapped
function's signature, which is a nice improvement.
@potiuk potiuk merged commit ad4717b into apache:main Aug 12, 2022
@uranusjr uranusjr deleted the paramspec-provide-session-for-autocomplete branch August 12, 2022 14:42
@ephraimbuddy ephraimbuddy added the type:improvement Changelog: Improvements label Aug 15, 2022
@ephraimbuddy ephraimbuddy added type:misc/internal Changelog: Misc changes that should appear in change log and removed type:improvement Changelog: Improvements labels Sep 14, 2022
@ephraimbuddy ephraimbuddy added this to the Airflow 2.4.0 milestone Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashb ashb ashb approved these changes

@potiuk potiuk potiuk approved these changes

Assignees
No one assigned
Labels
type:misc/internal Changelog: Misc changes that should appear in change log
Projects
None yet
Milestone
Airflow 2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@uranusjr @ashb @potiuk @ephraimbuddy